Skip to content

fixes getting docs from aliased namespace #402

Merged
heyLu merged 1 commit intopixie-lang:masterfrom
thomasmulvaney:fix-docs
Oct 21, 2015
Merged

fixes getting docs from aliased namespace #402
heyLu merged 1 commit intopixie-lang:masterfrom
thomasmulvaney:fix-docs

Conversation

@thomasmulvaney
Copy link
Copy Markdown
Member

Fixes #401

Would be nice to get some better tests around doc stuff any thoughts on best way to do this?

@heyLu
Copy link
Copy Markdown
Member

heyLu commented Oct 19, 2015

Neat! :)

We could execute something like pixie-vm -e '(require pixie.io/spit :as io) (doc io/spit)' in the tests, and check that it exits successfully. (We need some tests for pixie-vm anyway, so maybe just add it there.)

heyLu added a commit that referenced this pull request Oct 21, 2015
fixes getting docs from aliased namespace
@heyLu heyLu merged commit 7dd29ae into pixie-lang:master Oct 21, 2015
@heyLu
Copy link
Copy Markdown
Member

heyLu commented Oct 21, 2015

Thanks! (We still might want to add tests, but hopefully we'll have a nicer idea of how to do that later.)

@thomasmulvaney thomasmulvaney deleted the fix-docs branch October 21, 2015 14:28
@thomasmulvaney
Copy link
Copy Markdown
Member Author

I agree tests around calling pixie itself make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants